Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Centralized Docker configuration #38

Closed
arey opened this issue Jan 14, 2017 · 1 comment
Closed

Centralized Docker configuration #38

arey opened this issue Jan 14, 2017 · 1 comment

Comments

@arey
Copy link
Member

arey commented Jan 14, 2017

All Dockefile are quite similar. Maybe is there a way to factorized them into a single file? HTTP Port could be parameterized. Maven configuration could be move to the parent pom.

jpaszek added a commit to jpaszek/spring-petclinic-microservices that referenced this issue Jan 29, 2018
jpaszek added a commit to jpaszek/spring-petclinic-microservices that referenced this issue Jan 29, 2018
jpaszek added a commit to jpaszek/spring-petclinic-microservices that referenced this issue Jan 29, 2018
jpaszek added a commit to jpaszek/spring-petclinic-microservices that referenced this issue Jan 29, 2018
@arey
Copy link
Member Author

arey commented Jan 30, 2018

Thanks a lot @jpaszek
Feel free to contribute again :-)

@arey arey closed this as completed Jan 30, 2018
talha-01 pushed a commit to talha-01/microservices-ci-cd-pipeline-with-petclinic-app that referenced this issue Nov 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant