Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unnecessary if statement in 'toolFunctionCall' test code from OpenAiApiToolFunctionCallIT #1208

Merged
merged 2 commits into from
Aug 19, 2024

Conversation

fing9
Copy link
Contributor

@fing9 fing9 commented Aug 12, 2024

To improve the readability of the test, I removed the unnecessary if (responseMessage.toolCalls() != null) check

The if statement is redundant and will always evaluate to true, since assertThat(responseMessage.toolCalls()).isNotNull() ensures that toolCalls() is not null.

@fing9 fing9 changed the title Remove unnecessary if statement in 'toolFunctionCall' test code Remove unnecessary if statement in 'toolFunctionCall' test code from OpenAiApiToolFunctionCallIT Aug 12, 2024
@sobychacko sobychacko added this to the 1.0.0-M2 milestone Aug 19, 2024
@sobychacko sobychacko merged commit 58c292a into spring-projects:main Aug 19, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants