Override SimpleStepBuilder.faultTolerant() in FaultTolerantStepBuilder #3840
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fmbenhassine
added
the
status: waiting-for-triage
|
Good catch! Thank you for your PR. This will make the However, could you please add a failing test that passes with this PR? We need to get this covered by a test. Thank you upfront. |
fmbenhassine
added
in: core
pr-for: bug
status: waiting-for-reporter
Override SimpleStepBuilder.faultTolerant() in FaultTolerantStepBuilder to prevent creation of a new FaultTolerantStepBuilder when calling faultTolerant() on an existing FaultTolerantStepBuilder. Otherwise configuration, like chunkListeners, are lost.
|
Hi @benas, thanks for the feedback. I added a test. |
|
Hey @benas , can you merge this pr please? |
fmbenhassine
removed
the
status: waiting-for-reporter
|
@marbon87 Thank you for updating the PR by adding a test. I planned to merge the fix in the upcoming 4.3.3. |
fmbenhassine
added
the
for: backport-to-4.2.x
| import org.junit.Test; | ||
|
|
||
| import static org.junit.Assert.assertEquals; | ||
| import static org.mockito.Mockito.mock; |
There was a problem hiding this comment.
This import is not used, I will remove it on merge.
fmbenhassine
pushed a commit
that referenced
this pull request
May 11, 2021
Override SimpleStepBuilder.faultTolerant() in FaultTolerantStepBuilder to prevent creation of a new FaultTolerantStepBuilder when calling faultTolerant() on an existing FaultTolerantStepBuilder. Otherwise configuration, like chunkListeners, are lost. Issue #3840
|
LGTM. Rebased and merged as a43d3a5. Thank you for your contribution! |
fmbenhassine
pushed a commit
that referenced
this pull request
May 11, 2021
Override SimpleStepBuilder.faultTolerant() in FaultTolerantStepBuilder to prevent creation of a new FaultTolerantStepBuilder when calling faultTolerant() on an existing FaultTolerantStepBuilder. Otherwise configuration, like chunkListeners, are lost. Issue #3840
fmbenhassine
pushed a commit
that referenced
this pull request
May 11, 2021
Override SimpleStepBuilder.faultTolerant() in FaultTolerantStepBuilder to prevent creation of a new FaultTolerantStepBuilder when calling faultTolerant() on an existing FaultTolerantStepBuilder. Otherwise configuration, like chunkListeners, are lost. Issue #3840
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I had a failure in a step configuration when calling .faultTolerant() twice. That led to the problem that the chunkListener was not registered.
The reason is that calling .faultTolerant() on an existing FaultTolerantStepBuilder creates a new FaultTolerantStepBuilder but not all configurations, like ChunkListeners, are kept.
Although it was a mistake in my job config, i think it would be better to return the current FaultTolerantStepBuilder to prevent such mistakes.