Optimize ExitStatus#addExitDescription #3979
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Optimize ExitStatus#addExitDescription by reducing string allocations through: - avoid string allocation when the current description is empty - avoid string allocation when the given description is empty - avoid intermediate string allocation by allocating the correct buffer size
marschall
force-pushed
the
addExitDescription
branch
from
7fbb853 to
29e746f
Compare
fmbenhassine
added
the
for: backport-to-4.3.x
fmbenhassine
pushed a commit
that referenced
this pull request
Feb 13, 2023
Optimize ExitStatus#addExitDescription by reducing string allocations through: - avoid string allocation when the current description is empty - avoid string allocation when the given description is empty - avoid intermediate string allocation by allocating the correct buffer size Issue #3979
|
I love this kind of optimisations! LGTM 👍 Rebased and merged as b38226e. Thank you for your contribution! |
fmbenhassine
pushed a commit
that referenced
this pull request
Feb 13, 2023
Optimize ExitStatus#addExitDescription by reducing string allocations through: - avoid string allocation when the current description is empty - avoid string allocation when the given description is empty - avoid intermediate string allocation by allocating the correct buffer size Issue #3979
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Optimize ExitStatus#addExitDescription by reducing string allocations
through:
When profiling the string allocations in
ExitStatus#addExitDescriptionwhere showing up. They were mostly showing up throughExitStatus#and(ExitStatus).