Use isQuoteCharacter instead of direct char comparison in DelimitedLineTokenizer #682
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…mparison of chars
|
@LukaszCaputa Please sign the Contributor License Agreement! Click here to manually synchronize the status of this Pull Request. See the FAQ for frequently asked questions. |
|
@LukaszCaputa Thank you for signing the Contributor License Agreement! |
|
This affects me as well. |
fmbenhassine
added
in: infrastructure
status: waiting-for-triage
fmbenhassine
added
has: backports
|
LGTM. Rebased and merged as 7d45f2c. Thank you for your contribution! |
fmbenhassine
changed the title
fmbenhassine
added
for: backport-to-4.2.x
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In case the function is overloaded in children class that fix can guarantee proper code execution.