Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade to concourse-java-scripts 0.0.4 #23962

Closed
snicoll opened this issue Oct 29, 2020 · 3 comments
Closed

Upgrade to concourse-java-scripts 0.0.4 #23962

snicoll opened this issue Oct 29, 2020 · 3 comments
Assignees
@snicoll
Labels
type: task A general task
Milestone
2.4.12

Comments

@snicoll
Copy link
Member

snicoll commented Oct 29, 2020 •
edited
Loading

We need to make sure spring-io/concourse-java-scripts#11 is merged first.

When we upgrade we need to revert the workaround we've added for that issue.
@snicoll snicoll added the type: dependency-upgrade A dependency upgrade label Oct 29, 2020
@snicoll snicoll added this to the 2.2.x milestone Oct 29, 2020
snicoll added a commit that referenced this issue Oct 29, 2020
@snicoll
Merge branch '2.1.x' into 2.2.x
a8db6a8 
See gh-23962
@snicoll
Copy link
Member Author

snicoll commented Oct 29, 2020

I've moved this to 2.1.x as we'd need this as well in case we should ever release 2.1.x again.

@snicoll snicoll added type: task A general task and removed type: dependency-upgrade A dependency upgrade labels Oct 29, 2020
@snicoll snicoll modified the milestones: 2.2.x, 2.1.x Oct 29, 2020
snicoll added a commit that referenced this issue Oct 29, 2020
@snicoll
Merge branch '2.1.x' into 2.2.x
770b5f4 
See gh-23962
@snicoll snicoll changed the title Upgrade to github-changelog-generator 0.0.4 Upgrade to concourse-java-scripts 0.0.4 Oct 29, 2020
@philwebb philwebb removed this from the 2.1.x milestone Jun 15, 2021
@philwebb philwebb added status: declined A suggestion or change that we don't feel we should currently apply and removed type: task A general task labels Jun 15, 2021
@wilkinsona
Copy link
Member

Isn't this still needed as we're using 0.0.3 at the moment?

@wilkinsona wilkinsona added the for: team-attention An issue we'd like other members of the team to review label Jun 16, 2021
@wilkinsona wilkinsona reopened this Oct 4, 2021
@wilkinsona wilkinsona added type: task A general task and removed status: declined A suggestion or change that we don't feel we should currently apply for: team-attention An issue we'd like other members of the team to review labels Oct 4, 2021
@wilkinsona wilkinsona added this to the 2.4.x milestone Oct 4, 2021
@snicoll snicoll self-assigned this Oct 5, 2021
@snicoll
Copy link
Member Author

snicoll commented Oct 5, 2021

When we upgrade we need to revert the workaround we've added for that issue.

There's nothing to revert anymore as we use Gradle.

@snicoll snicoll mentioned this issue Oct 5, 2021
Closed
@snicoll snicoll modified the milestones: 2.4.x, 2.4.12 Oct 5, 2021
@snicoll snicoll closed this as completed in 1fc52b6 Oct 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@snicoll snicoll

Labels
type: task A general task
Projects
None yet
Milestone
2.4.12
Development

No branches or pull requests
3 participants
@snicoll @philwebb @wilkinsona