Skip to content

Add tests for BindableRuntimeHintsRegistrar #32851

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Add tests for BindableRuntimeHintsRegistrar #32851

wants to merge 1 commit into from

Conversation

tumit
Copy link
Contributor

@tumit tumit commented Oct 23, 2022

ref #32831

@pivotal-cla
Copy link

@tumit Please sign the Contributor License Agreement!

Click here to manually synchronize the status of this Pull Request.

See the FAQ for frequently asked questions.

@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Oct 23, 2022
@pivotal-cla
Copy link

@tumit Thank you for signing the Contributor License Agreement!

philwebb pushed a commit that referenced this pull request Nov 16, 2022
@tumit @philwebb
Add tests for BindableRuntimeHintsRegistrar
7e424bd 
See gh-32851
philwebb added a commit that referenced this pull request Nov 16, 2022
@philwebb
Polish 'Add test for BindableRuntimeHintsRegistrar'
13a4902 
See gh-32851
@philwebb philwebb closed this in d615185 Nov 16, 2022
@philwebb philwebb added type: task A general task and removed status: waiting-for-triage An issue we've not yet triaged labels Nov 16, 2022
@philwebb philwebb added this to the 3.0.0 milestone Nov 16, 2022
@philwebb
Copy link
Member

Thanks @tumit, I've merged this and also added more tests based on those in ConfigurationPropertiesBeanFactoryInitializationAotProcessorTests.

@philwebb philwebb mentioned this pull request Nov 16, 2022
Closed
philwebb added a commit that referenced this pull request Nov 17, 2022
@philwebb
Switch to use BeanUtils.getPropertyDescriptors
a293046 
Update `BindableRuntimeHintsRegistrar` to use
`BeanUtils.getPropertyDescriptors` rather than `BeanInfoFactory`.

Closes gh-33232

Closes gh-32851
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
type: task A general task
Projects
None yet
Milestone
3.0.0
Development

Successfully merging this pull request may close these issues.
4 participants
@tumit @pivotal-cla @philwebb @spring-projects-issues