Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide information about the source of the trust material in SslBundle's toString() #39057

Open
tkrah opened this issue Jan 8, 2024 · 3 comments
Labels
status: pending-design-work Needs design work before any code can be developed type: enhancement A general enhancement
Milestone

Comments

@tkrah
Copy link

tkrah commented Jan 8, 2024

Hi,

we are using different bundles and the one who does configure them and the one who does operate the app in question are not always the same person.
We're logging the used bundle, however we only get this as toString():

[org.springframework.boot.autoconfigure.ssl.PropertiesSslBundle@166e52ca]

Tomcat e.g. does print something like this for the connector config:

Connector [https-openssl-nio-8443], TLS virtual host [_default_], certificate type [UNDEFINED] configured from keystore [/home/app/.keystore] using alias [tomcat] with trust store [null]

It would be nice if a better toString could be done which prints all important configured props of the bundle (without sensitive stuff like passwords etc.), but ciphers, options, aliases, key / trust store path etc. would be nice to have on the configured bundle.

@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Jan 8, 2024
@philwebb philwebb added type: enhancement A general enhancement and removed status: waiting-for-triage An issue we've not yet triaged labels Jan 8, 2024
@philwebb philwebb added this to the 3.2.x milestone Jan 8, 2024
@philwebb philwebb changed the title SslBundle does miss an approriate toString() method Provide useful toString() results for SslBundle implementations Jan 8, 2024
@scottfrederick scottfrederick changed the title Provide useful toString() results for SslBundle implementations SslBundle implementations do not provide useful toString() results Jan 8, 2024
@scottfrederick scottfrederick added type: bug A general bug type: enhancement A general enhancement and removed type: enhancement A general enhancement type: bug A general bug labels Jan 8, 2024
@scottfrederick scottfrederick modified the milestones: 3.2.x, 3.x Jan 10, 2024
amparab added a commit to amparab/spring-boot that referenced this issue Jan 14, 2024
amparab added a commit to amparab/spring-boot that referenced this issue Jan 15, 2024
@amparab
Copy link
Contributor

amparab commented Jan 15, 2024

Hello, I have created a PR for this issue. Please let me know your suggestions for the same.

@tkrah
Copy link
Author

tkrah commented Jan 15, 2024

fyi, I'll add my suggestions / questions to the PR.

amparab added a commit to amparab/spring-boot that referenced this issue Jan 15, 2024
amparab added a commit to amparab/spring-boot that referenced this issue Jan 16, 2024
@wilkinsona wilkinsona changed the title SslBundle implementations do not provide useful toString() results Provide information about the source of the trust material in SslBundle's toString() Jan 17, 2024
@wilkinsona
Copy link
Member

I've merged the PR so we now have a toString() with some useful information but without the location from which the material was loaded. We'll keep this issue open to address that in the future.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: pending-design-work Needs design work before any code can be developed type: enhancement A general enhancement
Projects
None yet
6 participants