-
Notifications
You must be signed in to change notification settings - Fork 40.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Provide information about the source of the trust material in SslBundle's toString() #39057
Labels
status: pending-design-work
Needs design work before any code can be developed
type: enhancement
A general enhancement
Milestone
Comments
amparab
added a commit
to amparab/spring-boot
that referenced
this issue
Jan 14, 2024
…s of SslBundle
amparab
added a commit
to amparab/spring-boot
that referenced
this issue
Jan 15, 2024
…s of SslBundle
Hello, I have created a PR for this issue. Please let me know your suggestions for the same. |
fyi, I'll add my suggestions / questions to the PR. |
I've merged the PR so we now have a |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
status: pending-design-work
Needs design work before any code can be developed
type: enhancement
A general enhancement
Hi,
we are using different bundles and the one who does configure them and the one who does operate the app in question are not always the same person.
We're logging the used bundle, however we only get this as toString():
[org.springframework.boot.autoconfigure.ssl.PropertiesSslBundle@166e52ca]
Tomcat e.g. does print something like this for the connector config:
Connector [https-openssl-nio-8443], TLS virtual host [_default_], certificate type [UNDEFINED] configured from keystore [/home/app/.keystore] using alias [tomcat] with trust store [null]
It would be nice if a better toString could be done which prints all important configured props of the bundle (without sensitive stuff like passwords etc.), but ciphers, options, aliases, key / trust store path etc. would be nice to have on the configured bundle.
The text was updated successfully, but these errors were encountered: