Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add standardized property to distinguish a group of applications #39913

Closed
jonatan-ivanov opened this issue Mar 12, 2024 · 5 comments
Closed
Labels
status: superseded An issue that has been superseded by another

Comments

@jonatan-ivanov
Copy link
Member

jonatan-ivanov commented Mar 12, 2024

A property (e.g.: spring.application.namespace) that distinguishes group of applications (e.g.: the company/org/team that owns these apps) would be beneficial to the users.

In some cases spring.application.name needs to be unique for each app, multiple teams cannot use the same application name if they for example ship logs/metrics/traces/etc. to the same backend. With an additional "namespace" property, this would be much easier since spring.application.name only needs to be unique in the context of its "namespace".

This property could be used for

  • Log correlation: Boot logs out spring.application.name and it would be easier to search for application logs if there would be a "namespace" property available.
  • Metrics: the name and the "namespace" of the app can be added as tags (dimensions) so that teams would be able to aggregate metrics across these dimensions, e.g.: what is the error rate of all of the apps I own?
  • Tracing: similarly to log correlation, it helps to search for traces/spans.
  • Discovery: finding the owner of an app can be easier using the "namespace" as well as finding the applications that are owned by a team.
@jonatan-ivanov jonatan-ivanov added the status: waiting-for-triage An issue we've not yet triaged label Mar 12, 2024
@mhalbritter
Copy link
Contributor

so that teams would be able to aggregate metrics across these dimensions, e.g.: what is the error rate of all of the apps I own?

I really like this idea.

@mhalbritter mhalbritter added the for: team-attention An issue we'd like other members of the team to review label Mar 13, 2024
@csterwa
Copy link

csterwa commented Mar 13, 2024

In many of my conversations with development teams at different organizations, this is a common discussion topic. The ability to provide some indicator that a set of applications are part of a larger "business application" so that they can be viewed in metrics, portals, traces and more could be very helpful.

The term namespace may have be confused with the Kubernetes concept of Namespace. Maybe we need a few suggestions for the property name to choose from? I have a few here that may be candidates, as well:

  • spring.application.group
  • spring.application.family
  • spring.application.membership
  • spring.application.classification
  • spring.application.association

@philwebb
Copy link
Member

We like the suggestion and so far prefer spring.application.group as the property name.

@philwebb philwebb added type: enhancement A general enhancement and removed for: team-attention An issue we'd like other members of the team to review status: waiting-for-triage An issue we've not yet triaged labels Mar 13, 2024
@philwebb philwebb added this to the 3.x milestone Mar 13, 2024
@jonatan-ivanov
Copy link
Member Author

FWIW, I like group and family, group sounds a bit better: it sounds more neutral/natural for this.

wanger26 added a commit to wanger26/spring-boot that referenced this issue Mar 17, 2024
- Add a standardized property to provide some indicator that a set of applications are part of a larger "business application" so that they can be viewed in metrics, portals, traces and more

spring-projects#39913

Signed-off-by: Jakob Wanger <jakobwanger@gmail.com>
wanger26 added a commit to wanger26/spring-boot that referenced this issue May 7, 2024
- Add a standardized property to provide some indicator that a set of applications are part of a larger "business application" so that they can be viewed in metrics, portals, traces and more

spring-projects#39913

Signed-off-by: Jakob Wanger <jakobwanger@gmail.com>
wanger26 added a commit to wanger26/spring-boot that referenced this issue Jun 8, 2024
- Add a standardized property to provide some indicator that a set of applications are part of a larger "business application" so that they can be viewed in metrics, portals, traces and more

spring-projects#39913

Signed-off-by: Jakob Wanger <jakobwanger@gmail.com>
@philwebb
Copy link
Member

Closing in favor of PR #39957. Thanks @wanger26!

@philwebb philwebb closed this as not planned Won't fix, can't repro, duplicate, stale Jun 19, 2024
@philwebb philwebb added status: superseded An issue that has been superseded by another and removed type: enhancement A general enhancement labels Jun 19, 2024
@philwebb philwebb removed this from the 3.x milestone Jun 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: superseded An issue that has been superseded by another
Projects
None yet
Development

No branches or pull requests

4 participants