Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use constant for produces attribute of request mapping on BasicErrorController's errorHtml method #14501

Closed
wants to merge 1 commit into from

Conversation

specialys
Copy link
Contributor

Changed using MediaType static value.

@pivotal-issuemaster
Copy link

@yongsungjeon Please sign the Contributor License Agreement!

Click here to manually synchronize the status of this Pull Request.

See the FAQ for frequently asked questions.

@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Sep 18, 2018
@pivotal-issuemaster
Copy link

@yongsungjeon Thank you for signing the Contributor License Agreement!

@bclozel bclozel added this to the 2.1.x milestone Sep 18, 2018
@bclozel bclozel added type: enhancement A general enhancement and removed status: waiting-for-triage An issue we've not yet triaged labels Sep 18, 2018
@wilkinsona wilkinsona added type: task A general task and removed type: enhancement A general enhancement labels Sep 18, 2018
@wilkinsona wilkinsona changed the title BasicErrorController errorHtml produces change Use constant for produces attribute of request mapping on BasicErrorController's errorHtml method Sep 18, 2018
@snicoll snicoll self-assigned this Sep 19, 2018
@snicoll snicoll modified the milestones: 2.1.x, 2.1.0.M4 Sep 19, 2018
@snicoll snicoll closed this in 11864f2 Sep 19, 2018
snicoll added a commit that referenced this pull request Sep 19, 2018
* pr/14501:
  Use constant for produces attribute
@snicoll
Copy link
Member

snicoll commented Sep 19, 2018

@yongsungjeon thank you for making your first contribution to Spring Boot. This is now merged in master.

@specialys specialys deleted the develop branch September 19, 2018 09:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: task A general task
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants