-
Notifications
You must be signed in to change notification settings - Fork 40.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
(Obvious Fix) Add dependency management for JUnit Jupiter Aggregator #16330
(Obvious Fix) Add dependency management for JUnit Jupiter Aggregator #16330
Conversation
- in addition to Junit BOM this aggregator allows to add one-line dependency for Jupiter `api`, `engine` and `params`. See https://mvnrepository.com/artifact/org.junit.jupiter/junit-jupiter and https://github.com/junit-team/junit5/commits/master/junit-jupiter/junit-jupiter.gradle.kts for details.
@radistao Please sign the Contributor License Agreement! Click here to manually synchronize the status of this Pull Request. See the FAQ for frequently asked questions. |
@radistao This Pull Request contains an obvious fix. Signing the Contributor License Agreement is not necessary. |
@radistao |
@snicoll that's exactly what i wrote in the beginning of the PR description:
But the idea of this dependency is different: avoid dependencies "clogging" where it's possible. Obviously in almost all cases Jupiter is used with both As an example from existent Spring-boot dependencies:
If Spring-boot uses such approach, why JUnit can't be used in such a way? |
I know what the dependency is, we’ve actually asked for that feature. What do you think your change does exactly? Looking at the diff it is redundant to what the bom import does. Perhaps we can take a step back and you can describe the problem you’re trying to fix and how that change helps. |
ah, i see now, my bad: But current spring-boot So yeah, sorry for disturbing - i mixed up the versions. |
Obvious Fix
Enhancement
Additionally to JUnit Bom starting from version
5.4.0
the project provides JUnit Jupiter (Aggregator) dependency, which simplifies dependency management for common cases, e.g. when one needs onlyapi+engine+params
, which seems to be the most common case. Gradle example:Note: in the PR for new added
org.junit.jupiter:junit-jupiter
dependency I reused the same${junit-jupiter.version}
as fororg.junit:junit-bom
More detailed information: