Actuator endpoint time-to-live caching is not respected on WebFlux #18339
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spring-projects-issues
added
the
status: waiting-for-triage
|
Test failure seems unrelated |
philwebb
added
type: bug
philwebb
changed the title
philwebb
pushed a commit
that referenced
this pull request
Sep 29, 2019
Update `CachingOperationInvoker` so that TTL caching is applied directly to reactive types. Prior to this commit, a `Mono` would be cached, but the values that it emitted would not. See gh-18339
philwebb
added a commit
that referenced
this pull request
Sep 29, 2019
Extract reactor specific code to an inner class to protect against ClassNotFound exceptions if reactor is not in use. Also add support for `Flux`. See gh-18339
|
Thanks @dreis2211, this is now merged to 2.1.x and 2.2.x. I changing things slightly because I realized that we need to guard against reactor not being on the classpath. I also added |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
this PR is an attempt to fix #18324 . I'm not super familiar with the reactive side of things, but the proposed solution seems to fix the provided sample in #18324. A proper review and feedback is therefore highly appreciated.
Let me know what you think.
Cheers,
Christoph