Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhance Database initialization how to guide #21077

Closed
wants to merge 5 commits into from

Conversation

nikmanzotti
Copy link
Contributor

As discussed in #20920, I have enhanced the Database initialization guide clarifying the expected behavior when using a higher-level Database Migration Tool.

I also wanted to add a description for the spring.datasource.initialization-mode property, but I wasn't able to find the config-docs/data.adoc file. Proposed description for that property:

Type of datasource you want to initialize. Use always to initialize the DataSource regardless of its type.

@snicoll
Copy link
Member

snicoll commented Apr 25, 2020

That's excellent @nikmanzotti, thank you very much.

@snicoll
Copy link
Member

snicoll commented Apr 25, 2020

I also wanted to add a description for the spring.datasource.initialization-mode property

It is generated from the code, the current description is "Initialize the datasource with available DDL and DML scripts." I agree that this can be improved and we can do that as part of a separate issue. Type of datasource can be misleading IMO.

@snicoll snicoll added type: documentation A documentation update and removed status: waiting-for-triage An issue we've not yet triaged labels Apr 25, 2020
@snicoll snicoll self-assigned this Apr 25, 2020
snicoll pushed a commit that referenced this pull request Apr 25, 2020
@snicoll snicoll added this to the 2.2.7 milestone Apr 25, 2020
snicoll added a commit that referenced this pull request Apr 25, 2020
@snicoll snicoll closed this in 5ed27dd Apr 25, 2020
@snicoll
Copy link
Member

snicoll commented Apr 25, 2020

@nikmanzotti thank you for making your first contribution to Spring Boot.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: documentation A documentation update
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants