spring.data.redis.cluster.nodes and spring.data.redis.sentinel.nodes do not handle IPv6 addresses correctly #39819
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@tobi-laa Please sign the Contributor License Agreement! Click here to manually synchronize the status of this Pull Request. See the FAQ for frequently asked questions. |
spring-projects-issues
added
the
status: waiting-for-triage
|
@tobi-laa Thank you for signing the Contributor License Agreement! |
|
Fixed formatting. |
|
Fixed Checkstyle violation. Sorry, should have fixed that from the start. |
|
If you run |
wilkinsona
changed the title
wilkinsona
added
type: bug
wilkinsona
requested changes
Mar 15, 2024
...java/org/springframework/boot/autoconfigure/data/redis/PropertiesRedisConnectionDetails.java
Outdated
Show resolved
Hide resolved
...java/org/springframework/boot/autoconfigure/data/redis/PropertiesRedisConnectionDetails.java
Outdated
Show resolved
Hide resolved
wilkinsona
added
the
status: waiting-for-feedback
…s sentinel and cluster auto-config
|
@wilkinsona Thank you for the review! I updated the PR accordingly. |
spring-projects-issues
added
status: feedback-provided
wilkinsona
pushed a commit
that referenced
this pull request
Apr 22, 2024
wilkinsona
added a commit
that referenced
this pull request
Apr 22, 2024
|
@tobi-laa thanks very much for making your first contribution to Spring Boot. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When specifying colon-separated pairs of host and port with IPv6 addresses (i.e.
[::1]:6379) for eitherspring.data.redis.cluster.nodesorspring.data.redis.sentinel.nodes, the parsing of these nodes/addresses was broken as the splitting of these strings was not performed explicitly on the last found colon. The behavior is fixed with this PR.