Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing runtime hints for QueryDSL #2725

Closed
meistermeier opened this issue May 18, 2023 · 3 comments
Closed

Missing runtime hints for QueryDSL #2725

meistermeier opened this issue May 18, 2023 · 3 comments
Assignees

Comments

@meistermeier
Copy link
Collaborator

Just noticed in combination with Spring GraphQL that there is at least one missing entry in https://github.com/spring-projects/spring-data-neo4j/blob/main/src/main/java/org/springframework/data/neo4j/aot/Neo4jRuntimeHints.java .
Namely QuerydslNeo4jPredicateExecutor.class.
While I am here I was thinking why we didn't include the reactive counterparts here(?)
Pulling in @mp911de / @christophstrobl to the discussion.

@meistermeier meistermeier self-assigned this May 18, 2023
@mp911de
Copy link
Member

mp911de commented May 22, 2023

I assume that because of the evolutionary nature of native hints, we added hints for missing functionality that bubbled up as exceptions.

Please make sure to include hints for all imperative/reactive fragments and base repositories to be on the safe side.

@christophstrobl
Copy link
Member

@meistermeier you may draw some inspiration from here.

@meistermeier meistermeier added this to the 7.1.1 (2023.0.1) milestone Jun 1, 2023
@meistermeier
Copy link
Collaborator Author

Solved with e01b771 (main) and ce72f4d (7.1.x)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants