Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DATAJDBC-357 - Introduce dialect support to render paginated queries. #125

Closed
wants to merge 6 commits into from

Conversation

mp911de
Copy link
Member

@mp911de mp911de commented Mar 11, 2019

We now support Dialect abstractions to consider vendor-specific deviations in SQL query rendering. Dialects support right now:

  • Feature flags for array support
  • Limit and Offset handling

The rendering is extended by considering rendering callback hook functions.

Current dialects:

  • Postgres SQL
  • SQL Server (2012)
  • MySQL
  • (more to come)

@schauder schauder changed the title DATAJDBC-278 - Introduce dialect support to render paginated queries. DATAJDBC-357 - Introduce dialect support to render paginated queries. Apr 9, 2019
schauder pushed a commit that referenced this pull request Apr 9, 2019
We now support Dialect abstractions to consider vendor-specific deviations in SQL query rendering. Dialects support right now:

Feature flags for array support
Limit and Offset handling
The rendering is extended by considering rendering callback hook functions.

Current dialects:

Postgres SQL
SQL Server (2012)
MySQL

Original pull request: #125
schauder pushed a commit that referenced this pull request Apr 9, 2019
We now support Dialect abstractions to consider vendor-specific deviations in SQL query rendering. Dialects support right now:

Feature flags for array support
Limit and Offset handling
The rendering is extended by considering rendering callback hook functions.

Current dialects:

Postgres SQL
SQL Server (2012)
MySQL

Original pull request: #125.
schauder added a commit that referenced this pull request Apr 9, 2019
Implemented workaround for MySql not supporting offset without Limit.
Using `SELECT 1` as dummy order by since it is documented to be optimized away.
Renamed tests to match the project standard.

See also:

- https://stackoverflow.com/a/44106422
- https://stackoverflow.com/a/271650

Original pull request: #125.
@schauder
Copy link
Contributor

schauder commented Apr 9, 2019

Polished and merged.

@schauder schauder closed this Apr 9, 2019
@schauder schauder deleted the issue/DATAJDBC-278 branch April 9, 2019 13:39
mp911de added a commit that referenced this pull request Feb 21, 2022
We now reuse the existing Dialect infrastructure provided by Spring Data Relational to enhance it for R2DBC specifics such as bind markers.

Original pull request: #125.
mp911de added a commit that referenced this pull request Feb 21, 2022
Original pull request: #125.
mp911de added a commit that referenced this pull request Feb 21, 2022
Original pull request: #125.
mp911de pushed a commit that referenced this pull request Feb 21, 2022
Minor changes to documentation in order to avoid <literal code>``s constructs as recommended by our style guide.

Original pull request: #125.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants