Skip to content
This repository was archived by the owner on Sep 19, 2023. It is now read-only.

DATASOLR-86: Added support for range facets #29

Closed
wants to merge 14 commits into from
Closed

DATASOLR-86: Added support for range facets #29

wants to merge 14 commits into from

Conversation

juhrlass
Copy link
Contributor

Added FacetRangeOptions similar to FacetOptions that allows the creation of range facets.
Extended DefaultQueryParser and ResultHelper to support range facets in queries and results.

See: https://jira.springsource.org/browse/DATASOLR-86

juhrlass and others added 14 commits October 9, 2013 14:51
@juhrlass
Add basic support for facet ranges; support date ranges only with thi…
a5a9a3f 
…s commit
@juhrlass
changed range start and range end data type to date
1a51455
@juhrlass
support for NUMERIC and DATE ranges added
f3fd5c0
@juhrlass
support for field based sort
3f4aad5
Merge remote-tracking branch 'upstream/master'
fe8ffeb
Merge remote-tracking branch 'upstream/master'
0a60edd
@juhrlass
java doc updates
73f1edd
@juhrlass
Merge remote-tracking branch 'upstream/master'
270c04e 
Conflicts:
	src/main/java/org/springframework/data/solr/core/ResultHelper.java
	src/main/java/org/springframework/data/solr/core/SolrTemplate.java
@juhrlass
Merge remote-tracking branch 'upstream/master'
19b18d1
@juhrlass
add some tests
c994ad1
@juhrlass
add some tests and bugfixes
fce67e7
@juhrlass
DATASOLR-86: Add query params for other facet counts
ffe323f
@juhrlass
DATASOLR-86: refactoring of other,include and hardend query creation;…
0c25f21 
… update tests
@juhrlass
DATASOLR-86: small fixes and test updates
8187e8f
@christophstrobl
Copy link
Contributor

thank you @juhrlass for opening the pull request.
As I'm currently working on support for solr functions I'll try to have a closer look once I'm done with that.

One thing I'm actually not quite clear about is if there's the possibility to add ranges to the existing options...?
Cheers, Christoph.

@juhrlass
Copy link
Contributor Author

Hi Christoph,

FacetOptions and FacetRangeOptions are two separate things in this code. One can add additional FacetRangeOptions to a FacetQuery the result.
I get your point in having range options integrated in the FacetOptions similar to pivot facets.
Actually the code is something I used as a quick fix for date facetting in a productive environment.

Please tell me your opinion about this. Maybe I can help refactoring the code so that it fits better?

@ptahchiev
Copy link
Contributor

+1 on this :)

@michaelgriffithus
Copy link

When is this RangeFacet feature going to make it into the spring data solr code base?

@apoorvmittal10
Copy link

Any plans to merge it? Is there any other option to get facet range data using spring-data for the time the request not gets merged?

@Rene-Dieckmann
Copy link

+1 for merge

1 similar comment
@apoorvmittal10
Copy link

+1 for merge

@franciscospaeth franciscospaeth mentioned this pull request Jul 23, 2015
Closed
franciscospaeth pushed a commit that referenced this pull request Aug 2, 2015
@juhrlass @franciscospaeth
DATASOLR-86 - Add Support for Range Facets.
54c2175 
Intial implementation for range facets for NUMERIC and DATE.

Original Pull Request: #29 | #53
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@juhrlass @christophstrobl @ptahchiev @michaelgriffithus @apoorvmittal10 @Rene-Dieckmann