Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve documentation on inferred destruction callbacks #30745

Closed

Conversation

Nheyll
Copy link
Contributor

@Nheyll Nheyll commented Jun 25, 2023

I gave the #29546 a try.

  • I divided Destruction Callbacks section into two subsections, one for the inference of destroy methods and the other for the existing documentation on destruction callbacks.
  • I took the liberty to call the latter Explicit destruction methods in opposition to Inferred destruction methods.
  • Inferred destruction methods is written with a Java-first approach, with the the help of the Receiving Lifecycle Callbacks subsection which now references Inferred destruction methods.
  • I updated some references due to the addition of a new subsection.

@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged or decided on label Jun 25, 2023
@sbrannen sbrannen added type: documentation A documentation task in: core Issues in core modules (aop, beans, core, context, expression) labels Jun 25, 2023
@Nheyll Nheyll force-pushed the lifecycle-default-destroy-method branch from 00242a7 to a73e3c5 Compare July 4, 2023 17:00
@snicoll
Copy link
Member

snicoll commented Aug 24, 2023

Apologizes for missing this @Nheyll but @jhoeller has updated the documentation in the meantime, see #29546

@snicoll snicoll closed this Aug 24, 2023
@snicoll snicoll removed the status: waiting-for-triage An issue we've not yet triaged or decided on label Aug 24, 2023
@snicoll snicoll added the status: superseded An issue that has been superseded by another label Sep 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
in: core Issues in core modules (aop, beans, core, context, expression) status: superseded An issue that has been superseded by another type: documentation A documentation task
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants