Skip to content

Commit bab967c

Browse files
jbj338033bclozel
authored andcommitted
Leverage Java 17+ features for improved readability and performance
- Replace multi-line string concatenation with text blocks in HandlerMethod - Use String.formatted() instead of string concatenation in exception messages - Modernize string formatting using Java 17+ features These improvements enhance code readability and leverage modern Java capabilities while maintaining full backwards compatibility. All tests pass successfully. Closes gh-1320 Signed-off-by: jbj338033 <jbj338033@gmail.com>
1 parent 78a9812 commit bab967c

File tree

3 files changed

+7
-6
lines changed

3 files changed

+7
-6
lines changed

spring-graphql/src/main/java/org/springframework/graphql/data/method/HandlerMethod.java

Lines changed: 5 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -365,10 +365,11 @@ protected String formatInvokeError(String text, @Nullable Object[] args) {
365365
})
366366
.collect(Collectors.joining(",\n", " ", " "));
367367

368-
return text + "\n" +
369-
"Class [" + getBeanType().getName() + "]\n" +
370-
"Method [" + getBridgedMethod().toGenericString() + "] " +
371-
"with argument values:\n" + formattedArgs;
368+
return """
369+
%s
370+
Class [%s]
371+
Method [%s] with argument values:
372+
%s""".formatted(text, getBeanType().getName(), getBridgedMethod().toGenericString(), formattedArgs);
372373
}
373374

374375

spring-graphql/src/main/java/org/springframework/graphql/data/method/HandlerMethodArgumentResolverComposite.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -77,7 +77,7 @@ public boolean supportsParameter(MethodParameter parameter) {
7777
public @Nullable Object resolveArgument(MethodParameter parameter, DataFetchingEnvironment environment) throws Exception {
7878
HandlerMethodArgumentResolver resolver = getArgumentResolver(parameter);
7979
if (resolver == null) {
80-
throw new IllegalArgumentException("Unsupported parameter [" + parameter + "].");
80+
throw new IllegalArgumentException("Unsupported parameter [%s].".formatted(parameter));
8181
}
8282
return resolver.resolveArgument(parameter, environment);
8383
}

spring-graphql/src/main/java/org/springframework/graphql/server/support/GraphQlWebSocketMessageType.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -111,7 +111,7 @@ public static GraphQlWebSocketMessageType fromValue(String value) {
111111
return type;
112112
}
113113
}
114-
throw new IllegalArgumentException("No matching constant for [" + value + "]");
114+
throw new IllegalArgumentException("No matching constant for [%s]".formatted(value));
115115
}
116116

117117

0 commit comments

Comments
 (0)