Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typos in docs and classes #3226

Merged
merged 2 commits into from
May 3, 2024
Merged

Conversation

bky373
Copy link
Contributor

@bky373 bky373 commented Apr 30, 2024

Changes

  • annotation-error-handling.adoc
    • records -> things (Change to a more appropriate value)
  • events.adoc
    • ConsumerStartingEvent -> ConsumerStartedEvent (To remove duplicates)
  • listener-annotation.adoc
    • ProducerConfig -> ConsumerConfig (Change to a more appropriate value)
    • embeddedKafka.getBrokersAsString() -> "localhost:9092" (It's not necessary)
  • sending-messages.adoc
    • failedProducerRecord -> producerRecord (failedProducerRecord property does not exist)
  • serdes.adoc
    • contentMessageConverter -> contentTypeConverter (contentMessageConverter does not exist)
    • WHen -> When (typo)
  • replytopic/features.adoc
    • fixedBackoff -> fixedBackOff (fixedBackoff does not exist)
    • customBackOff -> customBackoff (customBackOff does not exist)
    • DeadLetterPublishingRecover -> DeadLetterPublishingRecoverer (typo)
  • ReplyingKafkaTemplate.java
    • start()ed -> started (typo)
  • BackOffValuesGenerator.java
    • checkBackOffPolicyTipe -> checkBackOffPolicyType (typo)
  • RetryTopicConfigurer.java
    • fixedBackoff -> fixedBackOff (fixedBackoff does not exist)

This document is truly awesome! It's been incredibly helpful for me to learn Spring Kafka.
I hope this PR is a small way to show my appreciation for all the help I've received.
I'd love to contribute code in the future. Thanks again!

@sobychacko sobychacko added this to the 3.2.0 milestone Apr 30, 2024
@sobychacko
Copy link
Contributor

@bky373 Thanks for the PR. It looks good. One minor comment. Can you add your name as an author using the @author tag in the three Java classes you modified?

@bky373
Copy link
Contributor Author

bky373 commented Apr 30, 2024

@bky373 Thanks for the PR. It looks good. One minor comment. Can you add your name as an author using the @author tag in the three Java classes you modified?

Sure! I updated the list. Thanks!

@sobychacko sobychacko merged commit b05510d into spring-projects:main May 3, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants