add birthdate validation in Pet Controller #1284
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dsyer
reviewed
Jul 7, 2023
src/main/java/org/springframework/samples/petclinic/owner/PetController.java
Outdated
Show resolved
Hide resolved
dsyer
reviewed
Jul 8, 2023
| @@ -6,3 +6,4 @@ nonNumeric=darf nur numerisch sein | |||
| duplicateFormSubmission=Wiederholtes Absenden des Formulars ist nicht erlaubt | |||
| typeMismatch.date=ung�ltiges Datum | |||
| typeMismatch.birthDate=ung�ltiges Datum | |||
| invalid.date=Ongeldige geboortedatum. Selecteer alstublieft een geldige datum. | |||
There was a problem hiding this comment.
german message is fixed now !
dsyer
reviewed
Jul 10, 2023
| @@ -107,6 +112,18 @@ public String initUpdateForm(Owner owner, @PathVariable("petId") int petId, Mode | |||
|
|
|||
| @PostMapping("/pets/{petId}/edit") | |||
| public String processUpdateForm(@Valid Pet pet, BindingResult result, Owner owner, ModelMap model) { | |||
|
|
|||
| if (StringUtils.hasLength(pet.getName()) && pet.isNew() && owner.getPet(pet.getName(), true) != null) { | |||
There was a problem hiding this comment.
Is this necessary - it's not a new pet, so the test will always fail?
There was a problem hiding this comment.
you are correct this was not there in the latest version .
sorry i maybe i added it by mistake
its fixed now in the new commit
|
Can you please squash everything down to one commit and rebase on main? Also take a look at the build failures and take the actions suggested (before you squash). |
|
Merged as 3be2895 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
adding birthdate for update and create Pet