Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OpenSaml4AuthenticationRequestResolver should have a customizable URI #10840

Closed
jzheaux opened this issue Feb 15, 2022 · 3 comments · Fixed by #11316
Closed

OpenSaml4AuthenticationRequestResolver should have a customizable URI #10840

jzheaux opened this issue Feb 15, 2022 · 3 comments · Fixed by #11316
Assignees
@deepakchethan
Labels
in: saml2 An issue in SAML2 modules type: enhancement A general enhancement
Milestone
5.8.0-M1

Comments

@jzheaux
Copy link
Contributor

jzheaux commented Feb 15, 2022 •
edited
Loading

Related to #8873

It would be nice if OpenSaml4AuthenticationRequestResolver could take a custom URI.
@jzheaux jzheaux added status: waiting-for-triage An issue we've not yet triaged type: enhancement A general enhancement status: ideal-for-contribution An issue that we actively are looking for someone to help us with in: saml2 An issue in SAML2 modules and removed status: waiting-for-triage An issue we've not yet triaged labels Feb 15, 2022
@jzheaux jzheaux changed the title OpenSaml4AuthenticationRequestResolver should have a customizable request matcher OpenSaml4AuthenticationRequestResolver should have a customizable URI Feb 15, 2022
@jzheaux jzheaux mentioned this issue Feb 18, 2022
Closed
@deepakchethan
Copy link

Hello, @jzheaux I would love to work on this. I'm pretty new to this codebase, would be great if you could give me some pointers. Thanks!

@marcusdacoregio
Copy link
Contributor

Hello @deepakchethan, thanks for volunteering, and welcome to the project!

I think adding a setRequestMatcher(RequestMatcher) to OpenSamlAuthenticationRequestResolver and do the same in OpenSaml4AuthenticationRequestResolver which in turn will call the OpenSamlAuthenticationRequestResolver::setRequestMatcher.

It is recommended to take a look at the contributing doc which can help you with some questions.

Feel free to ask any questions here.

@deepakchethan
Copy link

Hello @deepakchethan, thanks for volunteering, and welcome to the project!

I think adding a setRequestMatcher(RequestMatcher) to OpenSamlAuthenticationRequestResolver and do the same in OpenSaml4AuthenticationRequestResolver which in turn will call the OpenSamlAuthenticationRequestResolver::setRequestMatcher.

It is recommended to take a look at the contributing doc which can help you with some questions.

Feel free to ask any questions here.

Got it, Will get right on it. Thank you!

@houssemba houssemba mentioned this issue Jun 1, 2022
Merged
houssemba added a commit to houssemba/spring-security that referenced this issue Jun 5, 2022
@houssemba
make SAML authentication request uri configurable
4238f31 
Closes spring-projectsgh-10840
jzheaux pushed a commit that referenced this issue Jun 6, 2022
@houssemba @jzheaux
make SAML authentication request uri configurable
3310426 
Closes gh-10840
jzheaux pushed a commit that referenced this issue Jun 6, 2022
@houssemba @jzheaux
make SAML authentication request uri configurable
fc653bb 
Closes gh-10840
@jzheaux jzheaux removed the status: ideal-for-contribution An issue that we actively are looking for someone to help us with label Jun 6, 2022
@jzheaux jzheaux added this to the 5.8.0-M1 milestone Jun 6, 2022
@sjohnr sjohnr mentioned this issue Sep 16, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@deepakchethan deepakchethan

Labels
in: saml2 An issue in SAML2 modules type: enhancement A general enhancement
Projects
None yet
Milestone
5.8.0-M1
Development

Successfully merging a pull request may close this issue.

Make SAML authentication request uri configurable houssemba/spring-security
3 participants
@jzheaux @marcusdacoregio @deepakchethan