Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Site alert #105

Merged
merged 7 commits into from
Jun 24, 2024
Merged

Site alert #105

merged 7 commits into from
Jun 24, 2024

Conversation

liamjohnston
Copy link

@liamjohnston liamjohnston commented Jun 18, 2024

Needs a bunch of BED work, but ready for FED review.

Screenshot 2024-06-18 at 4 38 29 PM Screenshot 2024-06-18 at 4 38 49 PM

@liamjohnston liamjohnston requested a review from a team June 18, 2024 04:39
Copy link

@cameralibre cameralibre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FED good ✅

Comment on lines 18 to 21
.alert-banner--informational {
--alert-accent-color: var(--color-brand-100);
}
.alert-banner--warning {

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You could put these selectors together with a comma to make it clear that the same happens for both. Or set this variable on .alert-banner and only override it with --emergency

@liamjohnston liamjohnston marked this pull request as ready for review June 24, 2024 19:58
.exclude(display_from__gt=now)
.exclude(display_until__lt=now)
)
print(site_alerts)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Debugging

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed

@liamjohnston liamjohnston merged commit d2fe062 into main Jun 24, 2024
2 of 4 checks passed
@liamjohnston liamjohnston deleted the feature/site-alert branch June 24, 2024 23:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants