(fix) Fixed a bug loading the Kotlinx Module without use-fqn variable
#733
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for springwolf-ui canceled.
|
sam0r040
reviewed
Apr 30, 2024
...ation_model_converter/configuration/KotlinxSerializationModelConverterAutoConfiguration.java
Outdated
Show resolved
Hide resolved
timonback
approved these changes
May 1, 2024
When the Kotlinx Serialization Module was available in an environment without the `springwolf.use-fqn` the code was failing, since it was trying to inject the variable. The code is now loading the converter **only** if `springwolf.enabled` is `true` (default value). The `springwolf.use-fqn` is also defaulting to `true`. This solution fixes the identified issue.
ctasada
force-pushed
the
ctasada/fix-kotlinx-module-autoconfigure
branch
from
0c72f78
to
70d8f2d
Compare
timonback
reviewed
May 1, 2024
...ation_model_converter/configuration/KotlinxSerializationModelConverterAutoConfiguration.java
Outdated
Show resolved
Hide resolved
timonback
approved these changes
May 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the Kotlinx Serialization Module was available in an environment without the
springwolf.use-fqnthe code was failing, since it was trying to inject the variable.The code is now loading the converter only if
springwolf.enabledistrue(default value). Thespringwolf.use-fqnis also defaulting totrue.This solution fixes the identified issue.