Wrong vendor prefix for IE, different syntaxes for transform: matrix() #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ix syntax used by IE.
jtaby
added a commit
that referenced
this pull request
Aug 31, 2011
Wrong vendor prefix for IE, different syntaxes for transform: matrix()
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey guys, great work on the library!
One issue I'm having right now is that it currently uses the MS vendor prefix for IE, but the one used by Microsoft is actually ms (lowercased). That makes the transforms in IE9 fallback to filter:DXTransform, which is super slow and buggy.
Another issue I'm having is that there are two different syntaxes for the transform property. The one proposed by mozilla accepts units on the tx and ty components of the matrix, while the one proposed by Webkit does not. Strangely enough, Webkit seems to accept mozilla syntax just fine now, but IE only seems to accept the Webkit syntax. I made some changes on the library to reflect this, and I'm issuing a pull request.