Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor invalid keys handling #126

Merged
merged 2 commits into from
Oct 10, 2022
Merged

Refactor invalid keys handling #126

merged 2 commits into from
Oct 10, 2022

Conversation

w4ll3
Copy link
Member

@w4ll3 w4ll3 commented Oct 10, 2022

This refactor how invalid keys passed in the parameters of verify are handled.

@w4ll3 w4ll3 requested review from skgbafa and sbihel October 10, 2022 02:17
sbihel
sbihel approved these changes Oct 10, 2022
View reviewed changes
Copy link
Member

@sbihel sbihel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe a test is failing though

@w4ll3 w4ll3 merged commit 80feb1b into main Oct 10, 2022
@w4ll3 w4ll3 deleted the feat/improve-invalid-keys-check branch October 10, 2022 17:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sbihel sbihel sbihel approved these changes

@skgbafa skgbafa Awaiting requested review from skgbafa

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@w4ll3 @sbihel