Support optional scheme being provided in msg header #195
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
The EIP-4361 specification outlines the abnf message format that corresponds to a valid SiWE message. As seen below, this format indicates that there is an optional scheme that can pe provided alongside the domain in the first part of the message
Problem
The
siwe-parser
currently fails when a scheme is provided alongside the domain. This is due to the fact that our abnf grammar string currently lacks this[ scheme "://" ]
declaration in the grammar, resulting in valid SiWE messages containing this scheme to result in an error being thrown.Solution
This pull request does two things to solve this:
[ scheme "://" ]
to the grammar string