Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove resolveJsonModule to fix dist structure after build #91

Merged
merged 3 commits into from
Jul 18, 2022
Merged

Remove resolveJsonModule to fix dist structure after build #91

merged 3 commits into from
Jul 18, 2022

Conversation

w4ll3
Copy link
Member

@w4ll3 w4ll3 commented Jul 18, 2022

Remove resolveJsonModule flag introduced on the 2.0.4 release which changes the structure of the dist folder after building the package.

@wyc wyc self-requested a review July 18, 2022 21:02
wyc
wyc approved these changes Jul 18, 2022
View reviewed changes
Copy link
Contributor

@wyc wyc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ran tests locally, passing. The nested dist structure is gone.

@w4ll3 w4ll3 merged commit 23f7e17 into main Jul 18, 2022
@w4ll3 w4ll3 deleted the fix/dist-structure branch July 18, 2022 21:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wyc wyc wyc approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@w4ll3 @wyc