Improve DID URL dereferencing for verification methods #122
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Allow object to be embedded under other verification method arrays besides verificationMethod.
clehner
changed the title
4 tasks
sbihel
approved these changes
Mar 15, 2021
| .resolve(did, &ResolutionInputMetadata::default()) | ||
| .await; | ||
| if res_meta.error.is_some() { | ||
| return None; |
There was a problem hiding this comment.
Do we really want to hide this error? It could make the code a bit messy as we probably don't want to stop whatever operation is in progress because one resolution failed, but I'm afraid the potential error for the end user might be misleading.
There was a problem hiding this comment.
I agree this is not ideal. Issue opened: #126
clehner
force-pushed
the
feat/relative-did-url
branch
from
9c59562
to
2cad7cd
Compare
|
This PR was closed automatically, I think because I deleted the head branch before rebasing the PR branch and updating to base on |
This was referenced Mar 16, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Superceded by: #128