Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vendor json-ld crate #138

Merged
merged 1 commit into from
Mar 31, 2021
Merged

Vendor json-ld crate #138

merged 1 commit into from
Mar 31, 2021

Conversation

clehner
Copy link
Contributor

@clehner clehner commented Mar 23, 2021

Vendor the json-ld crate dependency using a git submodule, to enable publish to crates.io.

Progress for #136

Fixes #90

Includes #140, to get CI to work (Closes #140)

Cargo dependencies using git repo URLs cannot be used for publishing to crates.io (unless also including a registry version for publishing). We are depending on the json-ld crate with changes which are not yet published to crates.io. Without being able to depend on this two crates on crates.io, we must either fork and publish it to crates.io under a different name, or vendor it somehow. I wasn't able to get cargo vendor to work, and I'm not sure if that can be used (source replacement) with publishing to crates.io anyway. Instead, the approach taken here is to modify the package to make it work in ssi's workspace. It seems to be working to use a git submodule rather than having to include the repos' source files directly. The json-ld repos is forked and added to git submodules. The changes to json-ld are in the following PR, proposing to use a branch vendor for our fork: https://github.com/spruceid/json-ld/pull/1

  • cargo publish --dry-run works

@clehner clehner changed the title Vendor json and json-ld crates Vendor json-ld crate Mar 23, 2021
@clehner clehner marked this pull request as ready for review March 23, 2021 21:02
This was referenced Mar 24, 2021
@clehner clehner requested review from wyc and sbihel March 24, 2021 16:04
Cargo.toml Outdated Show resolved Hide resolved
@clehner clehner marked this pull request as draft March 29, 2021 15:28
@clehner clehner marked this pull request as ready for review March 29, 2021 15:28
@clehner
Copy link
Contributor Author

clehner commented Mar 29, 2021

Updated Notice file and Changelog

@wyc wyc self-requested a review March 31, 2021 13:55
Copy link
Contributor

@wyc wyc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

NOTICE update lgtm!

@clehner
Copy link
Contributor Author

clehner commented Mar 31, 2021

Thanks. Rebasing...

@clehner clehner merged commit 352a096 into main Mar 31, 2021
@clehner clehner deleted the feat/vendor-git-deps branch March 31, 2021 14:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Replacing git dependencies
3 participants