ecdsa-rdfc-2019 cryptosuite.
#555
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timothee-haudebourg
force-pushed
the
ecdsa-rdfc-2019
branch
2 times, most recently
from
43c1f76
to
0a7bafd
Compare
timothee-haudebourg
force-pushed
the
ecdsa-rdfc-2019
branch
from
0a7bafd
to
b6a51fc
Compare
sbihel
reviewed
Jul 3, 2024
crates/claims/crates/data-integrity/suites/src/suites/w3c/ecdsa_rdfc_2019.rs
Outdated
Show resolved
Hide resolved
sbihel
reviewed
Jul 3, 2024
crates/claims/crates/data-integrity/suites/src/suites/w3c/ecdsa_rdfc_2019.rs
Show resolved
Hide resolved
timothee-haudebourg
force-pushed
the
ecdsa-rdfc-2019
branch
from
b6a51fc
to
c2fda90
Compare
Add verification test.
timothee-haudebourg
force-pushed
the
ecdsa-rdfc-2019
branch
from
c2fda90
to
36c8975
Compare
sbihel
approved these changes
Jul 4, 2024
There was a problem hiding this comment.
I found that the failing VC API tests would pass if I tweaked EcdsaRdfc2019HashingAlgorithm to always use Sha256 (w3c/vc-di-ecdsa-test-suite#86) so this is good to be merged 👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implementation of the
ecdsa-rdfc-2019cryptosuite defined here: https://www.w3.org/TR/vc-di-ecdsa/#ecdsa-rdfc-2019