Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unused secret in CI and fix trigger #5

Merged
merged 2 commits into from
Oct 28, 2022
Merged

Remove unused secret in CI and fix trigger #5

merged 2 commits into from
Oct 28, 2022

Conversation

sbihel
Copy link
Member

@sbihel sbihel commented Oct 26, 2022

Using only the push trigger doesn't work for forks PRs.

@sbihel sbihel changed the title Remove unused secret in CI Remove unused secret in CI and fix trigger Oct 26, 2022
Copy link
Contributor

@lilyannehall lilyannehall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what were the github token and scope properties used for?

@sbihel
Copy link
Member Author

sbihel commented Oct 28, 2022

what were the github token and scope properties used for?

I'm unsure, I believe it was used to pull private packages (e.g. ssx-wasm-sdk) from our Github NPM repo, before things were published publicly.

@sbihel sbihel merged commit 7f9fb9e into spruceid:main Oct 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants