ECO-2057: AdyenApi Functional tests #3
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aleksey-kotsuba
requested review from
alex-galych,
pugach-ivan and
vhrychenko
limeeugenia
reviewed
Oct 29, 2018
| ); | ||
| $this->assertNotEmpty($responseTransfer->getCaptureResponse()->getPspReference()); | ||
| $this->assertNotEmpty($responseTransfer->getCaptureResponse()->getResponse()); | ||
| $this->assertEquals('[capture-received]', $responseTransfer->getCaptureResponse()->getResponse()); |
There was a problem hiding this comment.
Extract magic strings here and below to consts.
| */ | ||
| protected function createUtilEncodingService(): AdyenApiToUtilEncodingServiceInterface | ||
| { | ||
| $service = new UtilEncodingService(); |
There was a problem hiding this comment.
I think you can use locator to get these things here.
alex-galych
approved these changes
Nov 2, 2018
aleksey-kotsuba
force-pushed
the
feature/eco-1685/eco-2057-functional-tests
branch
from
af812aa
to
3fef478
Compare
aleksey-kotsuba
deleted the
feature/eco-1685/eco-2057-functional-tests
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Developer(s): @aleksey-kotsuba
Ticket: https://spryker.atlassian.net/browse/ECO-2057
PR: https://spryker.atlassian.net/browse/ECO-1891
Please confirm
Documentation
Release Table
Release Notes
Module AdyenApi
Minor: Added functionality in a backwards-compatible manner
Def of done (by responsible developer):
Change log
Improvements