Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ECO-1926 Make CRIF configurable #20

Merged
merged 3 commits into from
Aug 13, 2018
Merged

ECO-1926 Make CRIF configurable #20

merged 3 commits into from
Aug 13, 2018

Conversation

aleksey-kotsuba
Copy link
Contributor

Please confirm

  • No new OS components - or they have been approved by legal department
  • All new or heavily changed classes get an "A" rating (Scrutinizer), except Facades, Factories, QueryContainers and Tests

Documentation

  • Functional documentation provided or in progress?
  • Integration guide for projects provided or not needed?
  • Migration guides for all contained majors provided or not needed?

Release Table

Module Release Type Constraint Updates
Computop minor (new)

Release Notes

  • Make CRIF configurable - enable / disable.

Module Computop

Minor: Added functionality in a backwards-compatible manner

Def of done (by responsible developer):

  • All changes are backward-compatible. Outdated code is marked as deprecated.
  • New and changed facade methods covered by functional tests. / Has nothing to test.
  • New and changed complex business logic is covered by unit or integration tests. / Has nothing to test.
Change log

Improvements

  • Make CRIF configurable - enable / disable.

Aleksey Kotsuba added 2 commits August 8, 2018 10:50
ECO-1926:
e82f8c8 
 - add configuration enabled true/false;
 - update payment method filtering logic
 - update crif handler.
ECO-1926:
d1528e9 
 - fix Code style sniffer;
 - fix test's config.
@aleksey-kotsuba aleksey-kotsuba self-assigned this Aug 8, 2018
@aleksey-kotsuba aleksey-kotsuba merged commit 2a86628 into dev Aug 13, 2018
@aleksey-kotsuba aleksey-kotsuba deleted the feature/eco-79/eco-1926-make-crif-configurable branch August 13, 2018 10:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alex-galych alex-galych alex-galych approved these changes

Assignees

@aleksey-kotsuba aleksey-kotsuba

Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@aleksey-kotsuba @alex-galych