SDK-1267 fix a non-lazy commands loading bug #280
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sergeyspryker
requested review from
vol4onok,
pavelmaksimov25 and
Kyrylo-Meretskyi
vol4onok
reviewed
Nov 21, 2022
|
|
||
| foreach ($targetServiceIds as $serviceId => $tags) { | ||
| $definition = $container->getDefinition($serviceId); | ||
| $class = $definition->getClass(); |
There was a problem hiding this comment.
$container->getDefinition($serviceId)->getClass();
|
Please, write tests |
vol4onok
previously approved these changes
Nov 21, 2022
pavelmaksimov25
approved these changes
Nov 21, 2022
vol4onok
approved these changes
Nov 22, 2022
pavelmaksimov25
approved these changes
Nov 22, 2022
pavelmaksimov25
deleted the
bugfix/sdk-1267-fix-sdk-setting-initialization
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
Issue ticket link
Ticket: https://spryker.atlassian.net/browse/SDK-1267
Checklist before requesting a review