Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: context and entity improvements #1062

Merged
merged 16 commits into from
Jan 11, 2024

Conversation

dunqan
Copy link
Contributor

@dunqan dunqan commented Jan 11, 2024

  • Generic FieldsContextSerializers
  • getList and getListQualifiers for entity service

@dunqan dunqan requested a review from a team as a code owner January 11, 2024 13:33
Copy link

netlify bot commented Jan 11, 2024

Deploy Preview for dev-oryx-components ready!

Name Link
🔨 Latest commit 69a4575
🔍 Latest deploy log https://app.netlify.com/sites/dev-oryx-components/deploys/659fee242c85310008c5612e
😎 Deploy Preview https://deploy-preview-1062--dev-oryx-components.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Jan 11, 2024

Deploy Preview for dev-fulfillment ready!

Name Link
🔨 Latest commit 69a4575
🔍 Latest deploy log https://app.netlify.com/sites/dev-fulfillment/deploys/659fee24be3ad4000723e3c6
😎 Deploy Preview https://deploy-preview-1062--dev-fulfillment.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Jan 11, 2024

Deploy Preview for dev-composable-storefront ready!

Name Link
🔨 Latest commit 69a4575
🔍 Latest deploy log https://app.netlify.com/sites/dev-composable-storefront/deploys/659fee24aefbbe0008ca51d7
😎 Deploy Preview https://deploy-preview-1062--dev-composable-storefront.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
3 paths audited
Performance: 42 (🟢 up 1 from production)
Accessibility: 90 (no change from production)
Best Practices: 97 (no change from production)
SEO: 87 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Jan 11, 2024

Deploy Preview for dev-fulfillment ready!

Name Link
🔨 Latest commit 1c347c9
🔍 Latest deploy log https://app.netlify.com/sites/dev-fulfillment/deploys/659ffce4d64fbc00087af949
😎 Deploy Preview https://deploy-preview-1062--dev-fulfillment.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Jan 11, 2024

Deploy Preview for dev-oryx-components ready!

Name Link
🔨 Latest commit 1c347c9
🔍 Latest deploy log https://app.netlify.com/sites/dev-oryx-components/deploys/659ffce4735fc80007370ba9
😎 Deploy Preview https://deploy-preview-1062--dev-oryx-components.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

cypress bot commented Jan 11, 2024

2 failed tests on run #2996 ↗︎

2 3 0 0 Flakiness 0

Details:

Merge remote-tracking branch 'origin/development' into feature/context-and-entit...
Project: Fulfillment App Commit: 1c347c97dc
Status: Failed Duration: 14:52 💡
Started: Jan 11, 2024 2:47 PM Ended: Jan 11, 2024 3:02 PM
Failed  full-picking.cy.ts • 1 failed test • fa-regression

View Output Video

Test Artifacts
Fully pick a picking list > must pick all products successfully Test Replay Screenshots Video
Failed  partial-picking.cy.ts • 1 failed test • fa-regression

View Output Video

Test Artifacts
Partial pick a picking list > must pick all products successfully Test Replay Screenshots Video

Review all test suite changes for PR #1062 ↗︎

Copy link

cypress bot commented Jan 11, 2024

Passing run #12095 ↗︎

0 57 57 0 Flakiness 0

Details:

Merge remote-tracking branch 'origin/development' into feature/context-and-entit...
Project: Composable Storefront Commit: 1c347c97dc
Status: Passed Duration: 07:38 💡
Started: Jan 11, 2024 2:44 PM Ended: Jan 11, 2024 2:51 PM

Review all test suite changes for PR #1062 ↗︎

Copy link

netlify bot commented Jan 11, 2024

Deploy Preview for dev-composable-storefront ready!

Name Link
🔨 Latest commit 1c347c9
🔍 Latest deploy log https://app.netlify.com/sites/dev-composable-storefront/deploys/659ffce46aa50600081a5052
😎 Deploy Preview https://deploy-preview-1062--dev-composable-storefront.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
3 paths audited
Performance: 40 (🔴 down 1 from production)
Accessibility: 90 (no change from production)
Best Practices: 97 (no change from production)
SEO: 87 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@dunqan dunqan merged commit 80feadb into development Jan 11, 2024
34 of 36 checks passed
@dunqan dunqan deleted the feature/context-and-entity-improvements branch January 11, 2024 16:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants