refactor(ui): merge button and icon-button component #618
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for dev-composable-storefront ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for dev-oryx-components ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for dev-fulfillment ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Passing run #9142 ↗︎
Details:
This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. |
|||||||||||||||
Passing run #1923 ↗︎
Details:
This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. |
|||||||||||||||
Sinucid
suggested changes
Jul 18, 2023
Sinucid
suggested changes
Jul 18, 2023
Sinucid
suggested changes
Jul 27, 2023
libs/base/ui/overlays/notification/src/notification.component.spec.ts
Outdated
Show resolved
Hide resolved
libs/template/themes/design-tokens/src/backoffice/button.token.ts
Outdated
Show resolved
Hide resolved
libs/template/themes/design-tokens/src/storefront/button.token.ts
Outdated
Show resolved
Hide resolved
Sinucid
previously approved these changes
Jul 27, 2023
Sinucid
suggested changes
Jul 28, 2023
Sinucid
approved these changes
Jul 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The button component has gone through some changes. The button now supports an icon type, so that the icon-button component could be dropped.
closes: HRZ-3283
BREAKING CHANGE:
oryx-icon-buttonis removed, use<oryx-button type="icon">going forward.<button>or<a>element. While this is still supported, using theslot="custom", buttons will now create the button or link based on properties.typeproperty was previously used to indicate both the color and style. This has been separated, so that you can define thetypeusing theButtonTypeenum (solid,outline,iconortext) and the color using theButtonColorenum (primary,neutralorerror) separately.outlinewas set as a separate property, this property is removed and moved into theButtonTypeenum.sizeproperty is now limited to the values of theButtonType, so that other sizes (xsandxl) cannot be used on the button component.