Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: move fulfillment sw to application package #633

Merged
merged 8 commits into from
Jul 25, 2023
Merged

refactor: move fulfillment sw to application package #633

merged 8 commits into from
Jul 25, 2023

Conversation

aleespryker
Copy link
Contributor

@aleespryker aleespryker commented Jul 20, 2023 •
edited by jira bot
Loading

closes: HRZ-3311

@netlify
Copy link

netlify bot commented Jul 20, 2023 •
edited
Loading

✅ Deploy Preview for dev-composable-storefront canceled.

Name Link
🔨 Latest commit fba0a1e
🔍 Latest deploy log https://app.netlify.com/sites/dev-composable-storefront/deploys/64baa2076bbd6c00080d9009

@netlify
Copy link

netlify bot commented Jul 20, 2023 •
edited
Loading

✅ Deploy Preview for dev-fulfillment canceled.

Name Link
🔨 Latest commit fba0a1e
🔍 Latest deploy log https://app.netlify.com/sites/dev-fulfillment/deploys/64baa20754f63e0008aef7cf

@netlify
Copy link

netlify bot commented Jul 20, 2023 •
edited
Loading

✅ Deploy Preview for dev-oryx-components canceled.

Name Link
🔨 Latest commit fba0a1e
🔍 Latest deploy log https://app.netlify.com/sites/dev-oryx-components/deploys/64baa207de3f080008999869

@cypress
Copy link

cypress bot commented Jul 20, 2023 •
edited
Loading

Passing run #8908 ↗︎

0 40 0 0 Flakiness 0

Details:

refactor: fix fa e2e commands
Project: Composable Storefront Commit: fba0a1e0a7
Status: Passed Duration: 03:51 💡
Started: Jul 21, 2023 3:24 PM Ended: Jul 21, 2023 3:28 PM

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings.

@cypress
Copy link

cypress bot commented Jul 20, 2023 •
edited
Loading

1 flaky tests on run #1818 ↗︎

0 27 0 0 Flakiness 1

Details:

refactor: fix fa e2e commands
Project: Fulfillment App Commit: fba0a1e0a7
Status: Passed Duration: 05:24 💡
Started: Jul 21, 2023 3:25 PM Ended: Jul 21, 2023 3:30 PM
Flakiness  src/integration/partialy-picking-picklist.cy.ts • 1 flaky test • fa-regression

View Output Video

Test Artifacts
Partial picking a picklist > should check partial picking Output Screenshots Video

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings.

@aleespryker
Merge branch 'development' of https://github.com/spryker/oryx into re…
2dec6f5 
…factor/hrz-3311-move-fulfillment-sw-to-application-package
tolerants
tolerants requested changes Jul 21, 2023
View reviewed changes
apps/fulfillment/sw/main.ts Outdated Show resolved Hide resolved
libs/template/application/sw/index.ts Outdated Show resolved Hide resolved
tsconfig.base.json Outdated Show resolved Hide resolved
libs/template/application/sw/index.ts Outdated Show resolved Hide resolved
@aleespryker aleespryker merged commit 418a486 into development Jul 25, 2023
27 checks passed
@aleespryker aleespryker deleted the refactor/hrz-3311-move-fulfillment-sw-to-application-package branch July 25, 2023 12:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AndreyYevtukhov AndreyYevtukhov AndreyYevtukhov approved these changes

@tobi-or-not-tobi tobi-or-not-tobi tobi-or-not-tobi approved these changes

@tolerants tolerants tolerants approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@aleespryker @tolerants @tobi-or-not-tobi @AndreyYevtukhov