feat(experience): dynamic visibility based on screen size #643
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…bility-configuration-to-rules
…bility-configuration-to-rules
✅ Deploy Preview for dev-fulfillment ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for dev-composable-storefront ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for dev-oryx-components ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
4 failed tests on run #9035 ↗︎
Details:
|
||||||||||||||||||||||||
| Test | Artifacts | |
|---|---|---|
| SSR suite > must render Cart page |
Output
Screenshots
Video
|
|
| SSR suite > must render Checkout page |
Output
Screenshots
Video
|
|
This comment has been generated by cypress-bot as a result of this project's GitHub integration settings.
Passing run #1883 ↗︎
Details:
This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. |
|||||||||||||||
supproduction
requested changes
Jul 26, 2023
libs/platform/experience/composition/composition-components.controller.spec.ts
Outdated
Show resolved
Hide resolved
libs/platform/experience/composition/composition-components.controller.ts
Outdated
Show resolved
Hide resolved
libs/platform/experience/composition/composition-components.controller.ts
Outdated
Show resolved
Hide resolved
libs/platform/experience/composition/composition-components.controller.ts
Outdated
Show resolved
Hide resolved
libs/platform/experience/src/services/layout/default-layout.service.ts
Outdated
Show resolved
Hide resolved
libs/platform/experience/src/services/layout/default-layout.service.ts
Outdated
Show resolved
Hide resolved
libs/platform/experience/src/services/layout/default-layout.service.ts
Outdated
Show resolved
Hide resolved
libs/platform/experience/src/services/layout/default-layout.service.ts
Outdated
Show resolved
Hide resolved
tobi-or-not-tobi
suggested changes
Jul 26, 2023
libs/base/ui/structure/collapsible-text/collapsible-text.component.spec.ts
Outdated
Show resolved
Hide resolved
libs/platform/experience/composition/composition-components.controller.ts
Outdated
Show resolved
Hide resolved
libs/platform/experience/composition/composition-components.controller.ts
Outdated
Show resolved
Hide resolved
libs/platform/experience/composition/composition-components.controller.ts
Outdated
Show resolved
Hide resolved
tobi-or-not-tobi
approved these changes
Jul 26, 2023
libs/platform/experience/src/services/layout/default-screen.service.spec.ts
Show resolved
Hide resolved
supproduction
approved these changes
Jul 27, 2023
Sinucid
deleted the
feature/hrz-3268-move-components-visibility-configuration-to-rules
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes: HRZ-3268