Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: allow normalized i18n context values 0 #667

Merged

Conversation

aleespryker
Copy link
Contributor

@aleespryker aleespryker commented Jul 28, 2023

closes: HRZ-3316

@netlify
Copy link

netlify bot commented Jul 28, 2023

Deploy Preview for dev-composable-storefront ready!

Name Link
🔨 Latest commit 73db531
🔍 Latest deploy log https://app.netlify.com/sites/dev-composable-storefront/deploys/64c3c02cb5b3bb00084d9aaf
😎 Deploy Preview https://deploy-preview-667--dev-composable-storefront.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@netlify
Copy link

netlify bot commented Jul 28, 2023

Deploy Preview for dev-oryx-components ready!

Name Link
🔨 Latest commit 73db531
🔍 Latest deploy log https://app.netlify.com/sites/dev-oryx-components/deploys/64c3c02cde07820008f7eae3
😎 Deploy Preview https://deploy-preview-667--dev-oryx-components.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@netlify
Copy link

netlify bot commented Jul 28, 2023

Deploy Preview for dev-fulfillment ready!

Name Link
🔨 Latest commit 73db531
🔍 Latest deploy log https://app.netlify.com/sites/dev-fulfillment/deploys/64c3c02c7ecd630008903f76
😎 Deploy Preview https://deploy-preview-667--dev-fulfillment.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@cypress
Copy link

cypress bot commented Jul 28, 2023

Passing run #9179 ↗︎

0 14 36 0 Flakiness 0

Details:

fix: allow normalized i18 context values 0
Project: Composable Storefront Commit: 73db5318e6
Status: Passed Duration: 03:34 💡
Started: Jul 28, 2023 1:23 PM Ended: Jul 28, 2023 1:27 PM

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings.

@cypress
Copy link

cypress bot commented Jul 28, 2023

Passing run #1937 ↗︎

0 27 0 0 Flakiness 0

Details:

fix: allow normalized i18 context values 0
Project: Fulfillment App Commit: 73db5318e6
Status: Passed Duration: 04:11 💡
Started: Jul 28, 2023 1:23 PM Ended: Jul 28, 2023 1:27 PM

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings.

@tobi-or-not-tobi tobi-or-not-tobi changed the title fix: allow normalized i18 context values 0 fix: allow normalized i18n context values 0 Aug 1, 2023
@aleespryker aleespryker merged commit bacffa3 into development Aug 1, 2023
28 of 29 checks passed
@aleespryker aleespryker deleted the bugfix/hrz-3316-allow-i18n-contenxt-values-zero branch August 1, 2023 09:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants