Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use standard query language for brands #672

Merged
merged 1 commit into from
Jul 31, 2023
Merged

Conversation

tobi-or-not-tobi
Copy link
Contributor

We've been lower casing the brand names so far, and use an incorrect query (q=sony) instead of the dedicated query (brand=Sony).

@netlify
Copy link

netlify bot commented Jul 31, 2023

Deploy Preview for dev-composable-storefront ready!

Name Link
🔨 Latest commit 770def0
🔍 Latest deploy log https://app.netlify.com/sites/dev-composable-storefront/deploys/64c764f0d9903f0008580216
😎 Deploy Preview https://deploy-preview-672--dev-composable-storefront.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@netlify
Copy link

netlify bot commented Jul 31, 2023

Deploy Preview for dev-oryx-components ready!

Name Link
🔨 Latest commit 770def0
🔍 Latest deploy log https://app.netlify.com/sites/dev-oryx-components/deploys/64c764f07d83b000082e79ce
😎 Deploy Preview https://deploy-preview-672--dev-oryx-components.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@netlify
Copy link

netlify bot commented Jul 31, 2023

Deploy Preview for dev-fulfillment ready!

Name Link
🔨 Latest commit 770def0
🔍 Latest deploy log https://app.netlify.com/sites/dev-fulfillment/deploys/64c764f0051bba00080668e8
😎 Deploy Preview https://deploy-preview-672--dev-fulfillment.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@cypress
Copy link

cypress bot commented Jul 31, 2023

1 flaky tests on run #9223 ↗︎

0 42 0 0 Flakiness 1

Details:

use original brand names and standard query language for brands
Project: Composable Storefront Commit: 770def08eb
Status: Passed Duration: 03:58 💡
Started: Jul 31, 2023 8:22 AM Ended: Jul 31, 2023 8:26 AM
Flakiness  src/integration/cart.cy.ts • 1 flaky test • sf-regression

View Output Video

Test Artifacts
... > and the quantity is increased by input change > should update the cart totals after blur Output Screenshots Video

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings.

@cypress
Copy link

cypress bot commented Jul 31, 2023

Passing run #1954 ↗︎

0 27 0 0 Flakiness 0

Details:

use original brand names and standard query language for brands
Project: Fulfillment App Commit: 770def08eb
Status: Passed Duration: 04:22 💡
Started: Jul 31, 2023 7:43 AM Ended: Jul 31, 2023 7:47 AM

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings.

@tolerants tolerants merged commit ae4175f into development Jul 31, 2023
27 checks passed
@tolerants tolerants deleted the fix/brand-query branch July 31, 2023 08:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants