Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(experience): drop obsolete CompositionLayout.Tabular layout type and related logic from CompositionComponent #682

Merged
merged 3 commits into from
Aug 2, 2023

Conversation

Sinucid
Copy link
Contributor

@Sinucid Sinucid commented Aug 1, 2023

The layout's static tabs story was added for Gartner demo and currently is obsolete

closes: HRZ-86532

@netlify
Copy link

netlify bot commented Aug 1, 2023

Deploy Preview for dev-composable-storefront ready!

Name Link
🔨 Latest commit f5a1c17
🔍 Latest deploy log https://app.netlify.com/sites/dev-composable-storefront/deploys/64c8f6f4e758b50008bf2d1e
😎 Deploy Preview https://deploy-preview-682--dev-composable-storefront.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@netlify
Copy link

netlify bot commented Aug 1, 2023

Deploy Preview for dev-fulfillment ready!

Name Link
🔨 Latest commit f5a1c17
🔍 Latest deploy log https://app.netlify.com/sites/dev-fulfillment/deploys/64c8f6f496363e0008019817
😎 Deploy Preview https://deploy-preview-682--dev-fulfillment.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@netlify
Copy link

netlify bot commented Aug 1, 2023

Deploy Preview for dev-oryx-components ready!

Name Link
🔨 Latest commit f5a1c17
🔍 Latest deploy log https://app.netlify.com/sites/dev-oryx-components/deploys/64c8f6f40dcd4f0007081f98
😎 Deploy Preview https://deploy-preview-682--dev-oryx-components.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@cypress
Copy link

cypress bot commented Aug 1, 2023

1 flaky tests on run #9287 ↗︎

0 42 0 0 Flakiness 1

Details:

hrz-86532: cleanup
Project: Composable Storefront Commit: f5a1c1742b
Status: Passed Duration: 04:34 💡
Started: Aug 1, 2023 12:19 PM Ended: Aug 1, 2023 12:23 PM
Flakiness  src/integration/cart.cy.ts • 1 flaky test • sf-regression

View Output Video

Test Artifacts
... > and the quantity is increased by input change > should update the cart totals after blur Output Screenshots Video

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings.

@cypress
Copy link

cypress bot commented Aug 1, 2023

Passing run #1977 ↗︎

0 27 0 0 Flakiness 0

Details:

hrz-86532: cleanup
Project: Fulfillment App Commit: f5a1c1742b
Status: Passed Duration: 04:26 💡
Started: Aug 1, 2023 12:19 PM Ended: Aug 1, 2023 12:24 PM

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings.

Copy link
Contributor

@tobi-or-not-tobi tobi-or-not-tobi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you also drop the lines in CompositionComponent.renderComponent which is outdated as well?

@Sinucid Sinucid requested a review from a team as a code owner August 1, 2023 11:16
@tolerants
Copy link
Contributor

@tobi-or-not-tobi It already looks like a BC break for anyone who used tabular layout. Suggest deprecate it.

@tobi-or-not-tobi
Copy link
Contributor

tobi-or-not-tobi commented Aug 1, 2023

Yes, but the feature is 100% not working, nor used.
Hence, i'd not be too religious about this one.

@tolerants
Copy link
Contributor

@Sinucid Can you please add a scope experience for this fix and also rephrase a PR titile message to mention that that CompositionComponent is not supporting Tabular layout anymore. We shouldn't mention staff related to our stories in PR titles in case it's fix or feat, as long as storybook is our internal tool and customers shouldn't care about it and be bothered with release notes about it.

@Sinucid Sinucid changed the title fix: drop obsolete layout's tabs story fix(experience): drop obsolete "CompositionLayout.Tabular" layout type and related logic from CompositionComponent Aug 2, 2023
@tolerants tolerants changed the title fix(experience): drop obsolete "CompositionLayout.Tabular" layout type and related logic from CompositionComponent fix(experience): drop obsolete CompositionLayout.Tabular layout type and related logic from CompositionComponent Aug 2, 2023
@Sinucid Sinucid merged commit d149861 into development Aug 2, 2023
29 checks passed
@Sinucid Sinucid deleted the fix/hrz-86532-layout-broken-story branch August 2, 2023 09:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants