-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(experience): drop obsolete CompositionLayout.Tabular
layout type and related logic from CompositionComponent
#682
Conversation
✅ Deploy Preview for dev-composable-storefront ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for dev-fulfillment ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for dev-oryx-components ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
1 flaky tests on run #9287 ↗︎
Details:
src/integration/cart.cy.ts • 1 flaky test • sf-regression
This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. |
Passing run #1977 ↗︎
Details:
This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can you also drop the lines in CompositionComponent.renderComponent
which is outdated as well?
@tobi-or-not-tobi It already looks like a BC break for anyone who used tabular layout. Suggest deprecate it. |
Yes, but the feature is 100% not working, nor used. |
@Sinucid Can you please add a scope |
CompositionLayout.Tabular
layout type and related logic from CompositionComponent
The layout's static tabs story was added for Gartner demo and currently is obsolete
closes: HRZ-86532