feat: adds cart etag interceptor #746
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
supproduction
changed the base branch from
feat/hrz-89557-price-mode-component
to
pr-fixes
Base automatically changed from
pr-fixes
to
feat/hrz-89557-price-mode-component
September 5, 2023 13:40
1 failed and 2 flaky tests on run #9789 ↗︎
Details:
|
|||||||||||||||||||||||||||||||||
| Test | Artifacts | |
|---|---|---|
| Sorting on the Category page > default sorting applied even after clearing the sort parameter |
Output
Screenshots
Video
|
|
category.cy.ts • 1 flaky test • sf-regression
| Test | Artifacts | |
|---|---|---|
| Filtering on the Category page > should change products list when category filter is cleared |
Output
Screenshots
Video
|
|
cart.cy.ts • 1 flaky test • sf-regression
| Test | Artifacts | |
|---|---|---|
| ... > should show a global error if an error occurs while cart editing |
Output
Screenshots
Video
|
|
This comment has been generated by cypress-bot as a result of this project's GitHub integration settings.
Passing run #2249 ↗︎
Details:
This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. |
|||||||||||||||
dunqan
reviewed
Sep 6, 2023
| @@ -37,4 +37,8 @@ export const cartProviders: Provider[] = [ | |||
| CartTotalsProvider, | |||
| ...cartNormalizer, | |||
| ...cartsNormalizer, | |||
| // { | |||
There was a problem hiding this comment.
I commented out it because of CORS issue
| @@ -21,6 +21,7 @@ export module ApiCartModel { | |||
| thresholds?: unknown[]; | |||
| currency?: string; | |||
| store?: string; | |||
| etag?: string; | |||
There was a problem hiding this comment.
I'm thinking about more generic name in our UI model for cart, maybe version ?
dunqan
approved these changes
Sep 6, 2023
supproduction
merged commit b8c4a22
into
feat/hrz-89557-price-mode-component
11 of 14 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
adds etag
closes HRZ-89614