fix(search): search box on small screens #754
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for dev-composable-storefront ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for dev-oryx-components ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for dev-fulfillment ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
1 flaky test on run #9898 ↗︎
Details:
|
|||||||||||||||||||||
| Test | Artifacts | |
|---|---|---|
| Product details page suite > should show product details |
Output
Screenshots
Video
|
|
This comment has been generated by cypress-bot as a result of this project's GitHub integration settings.
1 flaky test on run #2304 ↗︎
Details:
|
|||||||||||||||||||||
| Test | Artifacts | |
|---|---|---|
| Partial picking a picklist > should check partial picking |
Output
Screenshots
Video
|
|
This comment has been generated by cypress-bot as a result of this project's GitHub integration settings.
aleespryker
reviewed
Sep 11, 2023
tolerants
requested changes
Sep 11, 2023
tobi-or-not-tobi
previously approved these changes
Sep 12, 2023
This is debatable, agreed. We do this as it's very early in the project and this will at then help the community rather then block them.
tolerants
requested changes
Sep 12, 2023
tolerants
approved these changes
Sep 12, 2023
tolerants
pushed a commit
that referenced
this pull request
Sep 13, 2023
Fix small screens experience of site search box component closes: HRZ-89724 (cherry picked from commit e18028d)
Merged
tolerants
added a commit
that referenced
this pull request
Sep 15, 2023
tolerants
pushed a commit
that referenced
this pull request
Sep 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix small screens experience of site search box component
closes: HRZ-89724