Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ui): button states styles #771

Merged

Conversation

Sinucid
Copy link
Contributor

@Sinucid Sinucid commented Sep 18, 2023

  • states-related styles of oryx-button were refactored a bit
  • fixed variants story of navigation-button component

closes: HRZ-89875

@Sinucid Sinucid requested a review from a team as a code owner September 18, 2023 12:56
@netlify
Copy link

netlify bot commented Sep 18, 2023

Deploy Preview for dev-oryx-components ready!

Name Link
🔨 Latest commit edad03f
🔍 Latest deploy log https://app.netlify.com/sites/dev-oryx-components/deploys/650848e7b14e6d00084638b0
😎 Deploy Preview https://deploy-preview-771--dev-oryx-components.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@netlify
Copy link

netlify bot commented Sep 18, 2023

Deploy Preview for dev-fulfillment ready!

Name Link
🔨 Latest commit edad03f
🔍 Latest deploy log https://app.netlify.com/sites/dev-fulfillment/deploys/650848e7142d340008a7c9c6
😎 Deploy Preview https://deploy-preview-771--dev-fulfillment.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@netlify
Copy link

netlify bot commented Sep 18, 2023

Deploy Preview for dev-composable-storefront ready!

Name Link
🔨 Latest commit edad03f
🔍 Latest deploy log https://app.netlify.com/sites/dev-composable-storefront/deploys/650848e7d83382000855cd07
😎 Deploy Preview https://deploy-preview-771--dev-composable-storefront.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
3 paths audited
Performance: 35
Accessibility: 95
Best Practices: 97
SEO: 87
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@cypress
Copy link

cypress bot commented Sep 18, 2023

Passing run #10002 ↗︎

0 13 37 0 Flakiness 0

Details:

hrz-89875: fixed oryx-button states-related styles
Project: Composable Storefront Commit: edad03fab5
Status: Passed Duration: 14:09 💡
Started: Sep 18, 2023 1:02 PM Ended: Sep 18, 2023 1:16 PM

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings.

@cypress
Copy link

cypress bot commented Sep 18, 2023

Passing run #2350 ↗︎

0 27 0 0 Flakiness 0

Details:

hrz-89875: fixed oryx-button states-related styles
Project: Fulfillment App Commit: edad03fab5
Status: Passed Duration: 04:06 💡
Started: Sep 18, 2023 1:01 PM Ended: Sep 18, 2023 1:05 PM

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings.

@Sinucid Sinucid merged commit 7ffd7eb into development Sep 18, 2023
29 of 30 checks passed
@Sinucid Sinucid deleted the fix/hrz-89875-navigation-button-variants-story-states branch September 18, 2023 14:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants