fix(experience): top header layout is broken on medium screens #889
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for dev-fulfillment ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for dev-composable-storefront ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for dev-oryx-components ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
2 flaky tests on run #11080 ↗︎
Details:
|
|||||||||||||||||||||||||||
| Test | Artifacts | |
|---|---|---|
| Product details page suite > should update prices when price mode changes |
Test Replay
Screenshots
Video
|
|
cart.cy.ts • 1 flaky test • sf-regression
| Test | Artifacts | |
|---|---|---|
| ... > should render empty cart if there are no items |
Test Replay
Screenshots
Video
|
|
Review all test suite changes for PR #889 ↗︎
Sinucid
suggested changes
Nov 13, 2023
libs/platform/experience/src/services/layout/plugins/types/flex/flex-layout.plugin.ts
Outdated
Show resolved
Hide resolved
tolerants
reviewed
Nov 13, 2023
libs/platform/experience/src/services/layout/plugins/types/flex/flex-layout.model.ts
Outdated
Show resolved
Hide resolved
|
Please add package name |
tolerants
changed the title
tolerants
previously approved these changes
Nov 13, 2023
Sinucid
previously approved these changes
Nov 13, 2023
tobi-or-not-tobi
dismissed stale reviews from Sinucid and tolerants
via
70285fe
tolerants
approved these changes
Nov 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We've added an option to the flex layout to specify whether items should warp to the next line. On the top header, we do not want this, which is the default behaviour.
closes: HRZ-90414