Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(application): aplication service worker sub-package exports ordering #901

Merged
merged 2 commits into from
Nov 15, 2023
Merged

fix(application): aplication service worker sub-package exports ordering #901

merged 2 commits into from
Nov 15, 2023

Conversation

Sinucid
Copy link
Contributor

@Sinucid Sinucid commented Nov 15, 2023 •
edited by jira bot
Loading

closes: HRZ-90262

@Sinucid Sinucid requested a review from a team as a code owner November 15, 2023 12:32
@netlify Netlify
Copy link

netlify bot commented Nov 15, 2023 •
edited
Loading

✅ Deploy Preview for dev-fulfillment ready!

Name Link
🔨 Latest commit
🔍 Latest deploy log https://app.netlify.com/sites/dev-fulfillment/deploys/6554d208fc33a5192aa1837e
😎 Deploy Preview https://deploy-preview-901--dev-fulfillment.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@netlify Netlify
Copy link

netlify bot commented Nov 15, 2023 •
edited
Loading

✅ Deploy Preview for dev-composable-storefront ready!

Name Link
🔨 Latest commit 78e3564
🔍 Latest deploy log https://app.netlify.com/sites/dev-composable-storefront/deploys/6554c398fcd76d0008ec70b0
😎 Deploy Preview https://deploy-preview-901--dev-composable-storefront.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@netlify Netlify
Copy link

netlify bot commented Nov 15, 2023 •
edited
Loading

✅ Deploy Preview for dev-oryx-components ready!

Name Link
🔨 Latest commit
🔍 Latest deploy log https://app.netlify.com/sites/dev-oryx-components/deploys/6554d1ce5edda119ef88606c
😎 Deploy Preview https://deploy-preview-901--dev-oryx-components.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@Sinucid Sinucid changed the title fix(application): service worker package exports ordering fix(application): aplication service worker sub-package exports ordering Nov 15, 2023
@cypress Cypress
Copy link

cypress bot commented Nov 15, 2023 •
edited
Loading

1 flaky test on run #11170 ↗︎

0 47 47 0 Flakiness 1

Details:

Empty-Commit
Project: Composable Storefront Commit: 78e3564353
Status: Passed Duration: 04:18 💡
Started: Nov 15, 2023 1:15 PM Ended: Nov 15, 2023 1:19 PM
Flakiness  src/integration/currencies.cy.ts • 1 flaky test • sf-regression

View
Output
Video

Test Artifacts
Currencies suite > should save the currency selection when navigating on site Test Replay Screenshots Video

Review all test suite changes for PR #901 ↗︎

@Sinucid Sinucid merged commit bf4bb8a into development Nov 15, 2023
37 of 38 checks passed
@Sinucid Sinucid deleted the fix/application-service-worker-exports-order branch November 15, 2023 14:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tolerants tolerants tolerants approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Sinucid @tolerants