-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: configurable forced color mode #907
Merged
tolerants
merged 2 commits into
development
from
feature/HRZ-90485-configurable-color-mode
Nov 18, 2023
Merged
feat: configurable forced color mode #907
tolerants
merged 2 commits into
development
from
feature/HRZ-90485-configurable-color-mode
Nov 18, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for dev-fulfillment ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for dev-oryx-components ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for dev-composable-storefront ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Passing run #11315 ↗︎
Details:
Review all test suite changes for PR #907 ↗︎ |
Sinucid
approved these changes
Nov 16, 2023
tolerants
approved these changes
Nov 17, 2023
…485-configurable-color-mode
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Oryx supports both dark and light mode colors, leveraging the device color mode or by an application color mode selector. However, some applications are not ready to go in dark mode. This is also the case for the Fulfillment App.
To still leverage the rich color palette, we introduce an option on the Oryx App (root) component to control forcing the light vs dark mode.
This feature can be enabled by providing a configuration on the application:
closes: HRZ-90485