Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: configurable forced color mode #907

Merged
merged 2 commits into from
Nov 18, 2023

Conversation

tobi-or-not-tobi
Copy link
Contributor

@tobi-or-not-tobi tobi-or-not-tobi commented Nov 16, 2023

Oryx supports both dark and light mode colors, leveraging the device color mode or by an application color mode selector. However, some applications are not ready to go in dark mode. This is also the case for the Fulfillment App.
To still leverage the rich color palette, we introduce an option on the Oryx App (root) component to control forcing the light vs dark mode.

This feature can be enabled by providing a configuration on the application:

appBuilder()
  ...
  .withOptions({
    'oryx-app': { colorMode: ColorMode.Light },
  })
  .create();

closes: HRZ-90485

@tobi-or-not-tobi tobi-or-not-tobi requested a review from a team as a code owner November 16, 2023 11:58
Copy link

netlify bot commented Nov 16, 2023

Deploy Preview for dev-fulfillment ready!

Name Link
🔨 Latest commit 2702fb8
🔍 Latest deploy log https://app.netlify.com/sites/dev-fulfillment/deploys/655893471997d80007774653
😎 Deploy Preview https://deploy-preview-907--dev-fulfillment.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Nov 16, 2023

Deploy Preview for dev-oryx-components ready!

Name Link
🔨 Latest commit 2702fb8
🔍 Latest deploy log https://app.netlify.com/sites/dev-oryx-components/deploys/65589347b567520008060eff
😎 Deploy Preview https://deploy-preview-907--dev-oryx-components.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Nov 16, 2023

Deploy Preview for dev-composable-storefront ready!

Name Link
🔨 Latest commit 2702fb8
🔍 Latest deploy log https://app.netlify.com/sites/dev-composable-storefront/deploys/6558934748ea1f0008bfcbea
😎 Deploy Preview https://deploy-preview-907--dev-composable-storefront.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

cypress bot commented Nov 16, 2023

Passing run #11315 ↗︎

0 44 3 0 Flakiness 0

Details:

Merge remote-tracking branch 'origin/development' into feature/HRZ-90485-configu...
Project: Composable Storefront Commit: 2702fb824d
Status: Passed Duration: 03:52 💡
Started: Nov 18, 2023 11:18 AM Ended: Nov 18, 2023 11:21 AM

Review all test suite changes for PR #907 ↗︎

@tolerants tolerants merged commit eda800f into development Nov 18, 2023
37 of 38 checks passed
@tolerants tolerants deleted the feature/HRZ-90485-configurable-color-mode branch November 18, 2023 11:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants