Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add wrapper layout for plugins #922

Merged
merged 6 commits into from
Nov 21, 2023

Conversation

supproduction
Copy link
Contributor

@supproduction supproduction commented Nov 21, 2023

adds wrapper layout

closes HRZ-90520

@supproduction supproduction requested a review from a team as a code owner November 21, 2023 10:26
Copy link

netlify bot commented Nov 21, 2023

Deploy Preview for dev-composable-storefront ready!

Name Link
🔨 Latest commit 00a1a2e
🔍 Latest deploy log https://app.netlify.com/sites/dev-composable-storefront/deploys/655c914e56d4ef0008fe641a
😎 Deploy Preview https://deploy-preview-922--dev-composable-storefront.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Nov 21, 2023

Deploy Preview for dev-fulfillment failed.

Name Link
🔨 Latest commit 00a1a2e
🔍 Latest deploy log https://app.netlify.com/sites/dev-fulfillment/deploys/655c914e865bec0008280f80

Copy link

netlify bot commented Nov 21, 2023

Deploy Preview for dev-oryx-components ready!

Name Link
🔨 Latest commit 00a1a2e
🔍 Latest deploy log https://app.netlify.com/sites/dev-oryx-components/deploys/655c914ecb46980008f12eba
😎 Deploy Preview https://deploy-preview-922--dev-oryx-components.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

cypress bot commented Nov 21, 2023

2 flaky tests on run #11424 ↗︎

0 48 48 0 Flakiness 2

Details:

Merge remote-tracking branch 'origin' into feature/layout-wrapper
Project: Composable Storefront Commit: 00a1a2e119
Status: Passed Duration: 03:18 💡
Started: Nov 21, 2023 11:20 AM Ended: Nov 21, 2023 11:23 AM
Flakiness  category.cy.ts • 1 flaky test • sf-b2b

View Output Video

Test Artifacts
Category suite > Product price mode change > should update price when price mode changes Test Replay Screenshots Video
Flakiness  product.cy.ts • 1 flaky test • sf-b2b

View Output Video

Test Artifacts
Product details page suite > should update prices when price mode changes Test Replay Screenshots Video

Review all test suite changes for PR #922 ↗︎

@supproduction supproduction merged commit 6c9d73f into development Nov 21, 2023
33 of 38 checks passed
@supproduction supproduction deleted the feature/layout-wrapper branch November 21, 2023 17:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants