Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: trailing slash routes to 404 #923

Merged
merged 5 commits into from
Nov 21, 2023

Conversation

supproduction
Copy link
Contributor

@supproduction supproduction commented Nov 21, 2023

closes HRZ-90521

@supproduction supproduction requested a review from a team as a code owner November 21, 2023 11:25
Copy link

netlify bot commented Nov 21, 2023

Deploy Preview for dev-fulfillment canceled.

Name Link
🔨 Latest commit 7e8a472
🔍 Latest deploy log https://app.netlify.com/sites/dev-fulfillment/deploys/655ce5a1e9260000082e9e9f

Copy link

netlify bot commented Nov 21, 2023

Deploy Preview for dev-oryx-components ready!

Name Link
🔨 Latest commit 7e8a472
🔍 Latest deploy log https://app.netlify.com/sites/dev-oryx-components/deploys/655ce5a16cd29100085c23e5
😎 Deploy Preview https://deploy-preview-923--dev-oryx-components.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Nov 21, 2023

Deploy Preview for dev-composable-storefront ready!

Name Link
🔨 Latest commit 7e8a472
🔍 Latest deploy log https://app.netlify.com/sites/dev-composable-storefront/deploys/655ce5a14c3c6c00085e574a
😎 Deploy Preview https://deploy-preview-923--dev-composable-storefront.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

cypress bot commented Nov 21, 2023

1 flaky test on run #11468 ↗︎

0 46 3 0 Flakiness 1

Details:

Merge remote-tracking branch 'origin' into bugfix/hrz-90521-router-slash
Project: Composable Storefront Commit: 7e8a47208c
Status: Passed Duration: 06:18 💡
Started: Nov 21, 2023 6:02 PM Ended: Nov 21, 2023 6:08 PM
Flakiness  src/integration/product.cy.ts • 1 flaky test • sf-regression

View Output Video

Test Artifacts
Product details page suite > should show product with relations Test Replay Screenshots Video

Review all test suite changes for PR #923 ↗︎

@supproduction supproduction merged commit fe84de8 into development Nov 21, 2023
35 of 38 checks passed
@supproduction supproduction deleted the bugfix/hrz-90521-router-slash branch November 21, 2023 19:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants